Re: [msmtp-users] Compilation error on OS X

[Martin Lambers <marlam@...23...>]

On Thu, 26. Oct 2006, 13:35:23 +0100, Michael Williams wrote:
> On Wed, Oct 25, 2006 at 10:18:31PM +0200, Martin Lambers wrote:
> >I changed the detection of the OpenSSL libraries in the configure
> >script. A test tarball is available at
> >http://www.marlam.de/msmtp-1.4.8.tar.bz2 .  Does this fix the problem?
> 
> Yes. Without LIBS=-lcyrpto, the configure script seems to correctly pick
> up the need for it. -lcrypto is added to gcc when called by make and it
> builds fine. config.log is available at
> http://www.pentangle.net/tmp/config-1.4.8.log.

Thank you very much. The attached patch has been applied. It will be
included in 1.4.8.

Martin


Index: ChangeLog
===================================================================
RCS file: /cvsroot/msmtp/msmtp/ChangeLog,v
retrieving revision 1.56
diff -u -r1.56 ChangeLog
--- ChangeLog   21 Aug 2006 18:52:03 -0000      1.56
+++ ChangeLog   26 Oct 2006 20:08:37 -0000
@@ -1,4 +1,7 @@
 Version 1.4.8 (not yet released):
+- Improved the configure check for the OpenSSL libraries. This fixes a build
+  failure on Mac OS X. Reported by Michael Williams, who also tested the fix.
+  Thanks!
 - Gnulib update. Removes the initialization of pkgdata_DATA from
   gnulib/Makefile.am, thanks to a fix by Bruno Haible. 'make install' will no
   longer create an empty directory $(pkgdatadir) anymore (the default for
Index: configure.ac
===================================================================
RCS file: /cvsroot/msmtp/msmtp/configure.ac,v
retrieving revision 1.16
diff -u -r1.16 configure.ac
--- configure.ac        21 Aug 2006 18:52:03 -0000      1.16
+++ configure.ac        26 Oct 2006 20:08:37 -0000
@@ -121,15 +121,19 @@
 if test "$want_openssl" = "yes" -a "$have_tls" = "no"; then
     have_openssl=no
     if test "$windows" = "yes"; then
-        AC_LIB_HAVE_LINKFLAGS([ssl32], [], [#include <openssl/ssl.h>],
-            [SSL_library_init();])
+        AC_LIB_HAVE_LINKFLAGS([ssl32], [eay32],
+           [#include <openssl/ssl.h>
+            #include <openssl/err.h>],
+            [SSL_library_init(); ERR_get_error(); ])
         if test "$HAVE_LIBSSL32" = yes; then
            have_openssl=yes
             LIBS="$LIBS $LIBSSL32"
         fi
     else
-        AC_LIB_HAVE_LINKFLAGS([ssl], [], [#include <openssl/ssl.h>],
-            [SSL_library_init();])
+        AC_LIB_HAVE_LINKFLAGS([ssl], [crypto],
+           [#include <openssl/ssl.h>
+            #include <openssl/err.h>],
+            [SSL_library_init(); ERR_get_error(); ])
         if test "$HAVE_LIBSSL" = yes; then
            have_openssl=yes
             LIBS="$LIBS $LIBSSL"