[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [msmtp-users] Bug introduced in version 1.4.29



Hello Nicolas,

thank you very much for your bug report and analysis.

On Fri, 19 Oct 2012 19:46:30 +0000, Nicolas Pouillard wrote:
> The thing is that the "bug fix" introduced in 1.4.29 also introduce
> this bug.
> 
> Namely line 1477 in msmtp.c
> 
> "if (from_hdr >= 0)" replaces "if (from_hdr == 0)" which then skips
> the reading of the forthcoming recipients.
> 
> Assuming  my  conclusions are  correct,  I  consider this  bug
> critical since this  makes the  flags --read-recipients  and
> --read-envelope-from incompatible.

I pushed a patch that reverts the change in line 1477. This means that
--read-envelope-from now again only works correctly on single-line From
headers; this limitation is now documented. 

Here is the patch:
http://msmtp.git.sourceforge.net/git/gitweb.cgi?p=msmtp/msmtp;a=commit;h=8cce4b3a079dc718e8319f3c094deca5b5926795

If nobody protests, I will release 1.4.30 very soon because I agree
that this bug is critical.

Martin

Attachment: signature.asc
Description: PGP signature