[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [msmtp-users] Password parameters patch



On Mon, 2 Jul 2012 15:08:31 +0100, Ambrevar wrote:
> I've found that msmtp crashes when '--passwordeval' parameter is
> used.  This is due to the parameters argument being set as "optional"
> in msmtp.c. Only one value to change to fix it.

Thanks for fixing this! I pushed this part of your patch:
http://msmtp.git.sourceforge.net/git/gitweb.cgi?p=msmtp/msmtp;a=commitdiff;h=72dab53eb39ae1e5539ae0a30f71f270f7e5ab5f

> Besides, there is sadly no '--password' parameter available. This is
> useful for using msmtp from an external program such as mutt, while
> not saving the password in any clear file. So I added support for the
> '--password' parameter.  Quite simple in fact, and seems to work
> pretty well.

The problem with this option is that it shows up in process lists (via
the ps utility, in /proc, and via several system calls), so it would
be unsafe to use. I did not push this part of your patch.

With --passwordeval, it should be possible to use secure password
storage (keyring or encrypted files or something else) and still give
the password on the command line.

Best regards,
Martin