Re: [msmtp-users] missing libintl LDFLAGS in Makefile.am

[Martin Lambers <marlam@...23...>]

Hi Roman!

On 18/05/11 12:28, Roman Bogorodskiy wrote:
> It appears msmtp has problems passing linker flags for libintl
> (gettext).
> 
> How to reproduce:
> 
> ./configure --without-libidn --without-libgsasl --with-ssl=no
> make
> 
> Should fail with something like:
> 
> conf.o(.text+0x91): In function `check_account':
> /usr/home/novel/ports_stuff/msmtp/work/msmtp-1.4.24/src/conf.c:711:
> undefined reference to `libintl_gettext'
> ... and a number of similar messages ...
> 
> Note all that 'without' configure knobs, we need them to make sure
> additional libs don't suck in libintl indirectly.
> 
> It happens because libintl flags are not listed in src/Makefile.am:
> 
> msmtp_LDADD =  $(tls_LIBS) $(libgsasl_LIBS) $(libidn_LIBS) $(libgnome_keyring_LIBS)
> 
> Probably it should look something like that:
> 
> msmtp_LDADD =  $(tls_LIBS) $(libgsasl_LIBS) $(libidn_LIBS) $(libgnome_keyring_LIBS) $(LTLIBINTL)
> 
> I have a similar fix to FreeBSD port and it seems to work: http://goo.gl/TFWbF
> 
> With the only exception that I patched src/Makefile.in in order not to
> bother with its regeneration.

Thanks for noting that! It is fixed now in msmtp and mpop, by adding
$(LIBINTL) to the *_LDADD line (LTLIBINTL may work too but is intended
for packages using libtool).

Martin