Re: [mpop-users] pipelining=off not working?

[Martin Lambers <marlam@...1...>]

On Wed, 10. Jan 2007, 10:36:54 -0600, Jeremy C. Reed wrote:
> On Wed, 10 Jan 2007, Martin Lambers wrote:
> 
> > On Tue, 09. Jan 2007, 23:54:35 -0600, Jeremy C. Reed wrote:
> > > Can the mpop --pipelining option still be honored either way though? It 
> > > seems like if the mpop user wants to turn it off, then it should turn off.
> > > 
> > > As it is now, the manual page is unclear. It should say the option is 
> > > ignored if the POP3 server announces it has PIPELINING capability.
> > 
> > Mpop can do the right thing automatically with all POP3 servers that
> > support CAPA. There should be no need for the user to change that.
> > I think this should remain the default behaviour.

After thinking again about this, maybe it would be best to add a
pipelining=auto setting and make it the default. Then, on and off could
force pipelining on or off regardless of the server capabilities, and
auto would keep the current default behaviour, which should be ok for
most users.

Would you like that better?

> Can you use this at least?
> 
> --- src/pop3.c.orig	2006-09-22 20:35:03.000000000 -0500
> +++ src/pop3.c	2007-01-09 20:29:22.000000000 -0600
> @@ -89,8 +88,12 @@
>   * begin to read its answers, and refill the command pipeline when the number of
>   * unanswered commands drops to PIPELINE_MIN.
>   */
> +#ifndef POP3_PIPELINE_MIN
>  #define POP3_PIPELINE_MIN	20
> +#endif
> +#ifndef POP3_PIPELINE_MAX
>  #define POP3_PIPELINE_MAX	100
> +#endif

Yes, this is a good idea regardless of the --pipelining behaviour.
I applied it, thanks.

Regards,
Martin